[AutoRelease] t2-policyinsights-2025-07-05-59782(can only be merged by SDK owner) #41914
+6,768
−4,920
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Policy Insights SDK for the 2025-07-05 auto-release by:
- Adding generated async and sync attestations operation tests (with skipped markers and placeholders for assertions)
- Bumping sample snippets’
x-ms-original-fileAPI version references from older versions to2024-10-01 - Adding sanitizers for sensitive data in
conftest.py
Reviewed Changes
Copilot reviewed 178 out of 197 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| generated_tests/test_policy_insights_attestations_operations_async.py | Introduces async attestations tests (skipped) |
| generated_tests/test_policy_insights_attestations_operations.py | Introduces sync attestations tests (skipped) |
| generated_samples/remediations_create_subscription_scope_resource_ids_filter.py | New sample with hard-coded subscription ID |
Comments suppressed due to low confidence (3)
sdk/policyinsights/azure-mgmt-policyinsights/generated_tests/test_policy_insights_attestations_operations_async.py:29
- This test currently has no assertions. Add basic checks (e.g.,
assert result, or verify expected properties) to ensure the client call returns valid data.
# please add some check logic here by yourself
sdk/policyinsights/azure-mgmt-policyinsights/generated_tests/test_policy_insights_attestations_operations.py:28
- Placeholder comment remains instead of real assertions. Provide checks like
assert any(r for r in response)or validate response schema to improve test coverage.
# please add some check logic here by yourself
sdk/policyinsights/azure-mgmt-policyinsights/generated_samples/remediations_create_subscription_scope_resource_ids_filter.py:31
- Hard-coded subscription ID can expose environment-specific details. Consider sourcing this value from an environment variable or configuration to avoid leaking IDs in sample code.
subscription_id="35ee058e-5fa0-414c-8145-3ebb8d09b6e2",
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/Azure/sdk-release-request/issues/6390
Recording test success
https://dev.azure.com/azure-sdk/internal/_build?definitionId=1018